-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ntfy.sh support #702
Comments
Hello @gorkem-bwl |
That’s a great addition indeed, and definitely worth addressing. Could you draft an implementation plan for this? You might also want to take a look at how Uptime Kuma handles it for some inspiration. |
Hey, @gorkem-bwl I have reviewed the email notification provider in Bluewave Uptime and the ntfy notification integration in Uptime Kuma to explore how we can integrate ntfy notifications into Bluewave Uptime. Here's a summary of my findings and proposed approach:
This approach aligns with the existing architecture of Bluewave Uptime while drawing inspiration from Uptime Kuma's modularity. Let me know if further refinements are needed! |
Thanks for pulling things together. However, please ensure that all the details are fully outlined in the implementation document. Using AI for the documentation is good, but this task requires a more committed approach. For instance, I don't see any mention of the UI options for ntfy.sh. What are other user inputs? (eg how do you handle authentication?). How do you plan to develop back-end related tasks? You can also remove "How Bluewave Uptime Manages Notifications" as it's not related to this task. Let me know your thoughts! |
Thanks for the feedback. I will rewrite the draft in a more detailed manner by tomorrow. |
Thank you. |
@aryanp-86 just wanted to check back here to see if there is any progress on your end. Thanks! |
Still working on it. Will update you soon. |
Hey @gorkem-bwl
Let me know if further refinements are needed! |
Looks good. Thanks for the detailed implementation plan. Let's move forward with this! |
@aryanp-86 I'm working on cleaning up the notification process and network service at the moment, so if you could start from the front end that would be great! We can work out the back end implementation once the refactoring is done 👍 |
Ok great. Actually, I am almost ready with the frontend code. Would you please ping me once the refactoring is done? |
Hi @aryanp-86 , Backend refactoring is mostly done, you should find it much easier to work with now hopefully. There's a couple open PRs that will make some changes, but they're mostly minor and shouldn't cause conflict with what you're working on. They'll likely be merged within 24 hours anyways. |
Ok great 👍 |
Just wanted to check back here guys :) |
Sorry for the delay. The backend code has been refactored in recent pr's. I will modify my code to the changes in a day or two. |
Thanks for the update! @aryanp-86 |
Hello @gorkem-bwl @ajhollid |
Great, thank you for your contribution. We will review as soon as possible! |
Ntfy.sh is a library that helps send push notifications to your phone or desktop via scripts from any computer, and/or using a REST API.
When integrated with BlueWave Uptime, it can send incidents to a smartphone running the ntfy application.
One advantage is that it's faster than email notifications.
The text was updated successfully, but these errors were encountered: