-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kickoff/Complete/Collect crashes with an attribute error when using internal trigger on standard det #603
Comments
This change was made in response to the comment here: #568 (comment). @coretl may have more context on the necessity of this requirement. |
We want to be able to parallelize the slow operations of our flyscan:
But actually we might want to do the same flyscan 10 times at different energies, so we decided that we should be able to arm for multiple runs at the start:
We decided that we should put the arm in @ZohebShaikh I'm not sure if we explored that as an option? |
When using a standard detector in internal trigger mode, trying to use kickoff/complete/collect, will crash with an attribute error because
self._fly_start
is never set because of this conditional:ophyd-async/src/ophyd_async/core/_detector.py
Line 331 in e291396
Is there a reason we need this conditional? Everything works fine if I just remove it. Using kickoff/complete/collect with internal trigger is something I want to do because we want to be able to re-use the same plan for both the
everything is hardware triggered
experiment, and theeverything is timestamped
experiment.Steps To Reproduce
Steps to reproduce the behavior:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: