-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make an ADR on signal types and enforce #601
Milestone
Comments
Draft
Agreed. #594 will do the type checking. https://github.com/bluesky/ophyd-async/pull/594/files#r1790651259 shows the types that will be in the ADR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following #310 (comment) we have a well defined list of types that signals are allowed. However, there are still old devices in
dodal
that use different types e.g. https://github.com/DiamondLightSource/dodal/blob/f2e63c2c55d49ed35cef73531be7d4bcceb42546/src/dodal/devices/zocalo/zocalo_results.py#L133. To make sure these get phased out and more don't get introduced we should prohibit other types ideally through the typing system. To make it clear why this is the case we should make an ADR too.Acceptance Criteria
soft_signal_r_and_setter(MyArbitraryType)
the type system will complainThe text was updated successfully, but these errors were encountered: