Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support the formalized pvi structure from PandA #373

Open
coretl opened this issue Jun 11, 2024 · 1 comment
Open

Only support the formalized pvi structure from PandA #373

coretl opened this issue Jun 11, 2024 · 1 comment
Assignees
Milestone

Comments

@coretl
Copy link
Collaborator

coretl commented Jun 11, 2024

At the moment a pvi structure has a pvi field which contains the PVs for that Device. This is unlike any of the other records with have a value field instead.

PandABlocks/PandABlocks-ioc#120 will change all of this so that:

  • typeid is epics:nt/NTPVI:1.0
  • entries are in value not pvi

This means we can:

  • Rename PvaDictConverter to PvaPviConverter, and remove all the methods apart from value
  • Use PvaPviConverter where we see typeid epics:nt/NTPVI:1.0
  • Remove
    def metadata_fields(self) -> List[str]:
    """
    Fields to request from PVA for metadata.
    """
    return ["alarm", "timeStamp"]
    def value_fields(self) -> List[str]:
    """
    Fields to request from PVA for the value.
    """
    return ["value"]
    and hardcode them where they are used

This will require PandA IOC to be updated in sync with this change, but this is fine as we are pre-1.0

@coretl
Copy link
Collaborator Author

coretl commented Jun 11, 2024

To be done after June experiment

@coretl coretl added this to the 1.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants