Update dependencies to make tests pass #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glue.qglue was removed in v 0.18.0 See https://github.com/glue-viz/glue/blob/main/CHANGES.md#other-changes
This is now required by Tiled since v0.1.0a117
padraic-shafer
requested review from
danielballan,
tacaswell,
mrakitin and
genematx
|
Passes linter and unit tests in GH actions. NOTE: duplicate branch linked here to spur GH actions (which currently are not configured for manual |
danielballan
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests are failing in GitHub CI and locally on my laptop.
Updates
Bonus
Motivation and Context
Currently tests are failing; these changes enable test suite to pass without loss of functionality.
How Has This Been Tested?
Tested locally on MacOS (M2) with fresh instances of Mongo:(5, 6, 7) available on port 27017 (pulled from official docker hub mongo images) and with tiled image from
databroker/docker-compose.yml.