Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluesky plan_stubs not recognized with Bluesky v1.13.0a4 #305

Open
canismarko opened this issue Aug 5, 2024 · 2 comments
Open

Bluesky plan_stubs not recognized with Bluesky v1.13.0a4 #305

canismarko opened this issue Aug 5, 2024 · 2 comments

Comments

@canismarko
Copy link

Expected Behavior

If I import bluesky plan stubs in my queueserver startup file, they should be available in the queueserver as plans. This was the behavior when using bluesky v1.13.0a3 and below.

Current Behavior

The plan stubs are not available.

Possible Solution

Queueserver uses inspect.isgeneratorfunction() to determine if a token corresponds to a valid plan. With bluesky v1.13.0v4, plan stubs are now wrapped and no longer pass this check.

@tacaswell's suggestion is to include a separate check to detect these wrapped plan stubs: bluesky/bluesky#1779 (comment)

Steps to Reproduce (for bugs)

  1. Install Bluesky v1.13.0a4
  2. Write a queuerserver startup file that imports from bluesky.plan_stubs import mv
  3. Start the queueserver
  4. Look at the list of available plans.

Context

We use the queueserver for executing scans at our beamline. We include a few plan stubs for making adjustments to the beamline in-line in the queue.

Your Environment

https://gist.github.com/canismarko/39d39055a71b165faba801872162f7ba

@canismarko
Copy link
Author

Fixed: bluesky/bluesky#1780

@dmgav
Copy link
Contributor

dmgav commented Sep 27, 2024

Resolved in #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants