-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nicer Tabs] New native pager #6868
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7429be2
Remove tab bar autoscroll
gaearon d8a5515
Track pager drag gesture in a worklet
gaearon 32120ce
Track pager state change in a worklet
gaearon 35c451f
Track offset relative to current page
gaearon 7cad249
Sync scroll to swipe
gaearon 63388e8
Extract TabBarItem
gaearon ca1ee56
Sync scroll to swipe properly
gaearon 21ff405
Implement all interactions
gaearon 23f900c
Clarify more hacks
gaearon 5d9291d
Simplify the implementation
gaearon 6f9bc56
Interpolate the indicator
gaearon 2811862
Fix an infinite swipe loop
gaearon 65842a7
Add TODO
gaearon 01ad1d8
Animate header color
gaearon 9b94333
Respect initial page
gaearon 4f33328
Keep layouts in a shared value
gaearon f3e9a87
Fix profile and types
gaearon fadb2d0
Fast path for initial styles
gaearon dd45704
Scroll to initial
gaearon 80bd82e
Factor out a helper
gaearon 287d5b3
Fix positioning
gaearon a0deb8f
Scroll into view on tap if needed
gaearon f129a92
Divide free space proportionally
gaearon 3325752
Scroll into view more aggressively
gaearon cf586df
Fix corner case
gaearon a93e2b9
Ignore spurious event on iOS
gaearon 44cea4e
Simplify the condition
gaearon 05da3ad
Change boolean state to enum
gaearon 50f50fb
Better syncing heuristic
gaearon 129070f
Rm extra return
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was a way to express platforms in the type system :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably hack something together for this in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, some sort of monad perhaps