Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_range functionality for Ping360 #122

Open
ES-Alexander opened this issue Mar 7, 2022 · 1 comment · May be fixed by #123
Open

Add set_range functionality for Ping360 #122

ES-Alexander opened this issue Mar 7, 2022 · 1 comment · May be fixed by #123
Assignees
Milestone

Comments

@ES-Alexander
Copy link
Contributor

ES-Alexander commented Mar 7, 2022

Details discussed in a forum post:

[@EliotBR]

[@yuki]
Can an effective range be set up in ping360.py?

The range per sample is determined by the sample_period , so the total range is determined by sample_period and number_of_samples , together with the speed of sound in the water you’re operating in (see here if you want to estimate it from vehicle data, and here for estimating salinity).

If you want to make a set_range function, it may be worth looking at how it’s implemented in Ping Viewer 🙂

Speed of sound could either be set at the start (most user-friendly), or specified in the set_range function call (slightly simpler to implement)

@ES-Alexander ES-Alexander added this to the 0.2.0 milestone Mar 7, 2022
@ES-Alexander ES-Alexander self-assigned this Mar 7, 2022
@ES-Alexander
Copy link
Contributor Author

ES-Alexander commented Mar 18, 2022

Additional discussion/fleshing out the steps in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant