Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Somehow initialize ping_message function to avoid magic numbers. #2

Open
patrickelectric opened this issue Jun 25, 2019 · 1 comment
Open

Somehow initialize ping_message function to avoid magic numbers. #2

patrickelectric opened this issue Jun 25, 2019 · 1 comment

Comments

@patrickelectric
Copy link
Member

https://github.com/bluerobotics/ping-viewer/pull/522/files#r297255444
@jaxxzer
Copy link
Member

jaxxzer commented Jun 25, 2019

This is the intended use case of this constructor. I can define on my own a ping message and populate it/access it by hand. The type of application is less common, as in this never-documented legacy use-case, or if I just wanted to experiment with firmware without modifying three repositories in the build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickelectric @jaxxzer