Do not try to process videos as soon as the recording stops #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
requested review from
patrickelectric,
ArturoManzoli and
JoaoMario109
| @@ -144,8 +144,9 @@ watch(nameSelectedStream, () => { | |||
|
|
|||
| // Fetch temporary video data from the storage | |||
| const fetchNumebrOfTempVideos = async (): Promise<void> => { | |||
| const size = await videoStore.videoStoringDB.length() | |||
There was a problem hiding this comment.
This line has changed slightly recently, so probably is going to conflict with the pr #874 changes.
There was a problem hiding this comment.
Fixed!
Just to notice: I'm including both processed and unprocessed videos on the counting, as the unprocessed ones will also appear in the modal after your PR.
ArturoManzoli
approved these changes
Apr 12, 2024
As we are disabling auto-processing, it is the expected behavior as of now that the user has pending videos to be processed.
rafaellehmkuhl
force-pushed
the
stop-auto-processing
branch
from
9d5d6fc to
fd2f8ab
Compare
|
Talking to @ArturoManzoli we decided that this PR is merged but should not be merged until his following PR, which presents to the user the option to process the videos, is merged. Will put in draft till that. |
rafaellehmkuhl
force-pushed
the
stop-auto-processing
branch
from
fd2f8ab to
93fd057
Compare
|
Commits merged inside #895. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #878