Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear temporary video cache" button does not work properly if there are saved videos #736

Closed
rafaellehmkuhl opened this issue Feb 16, 2024 · 2 comments · Fixed by #752
Closed
Assignees
Labels
bug Something isn't working

Comments

@rafaellehmkuhl
Copy link
Member

No description provided.

@rafaellehmkuhl rafaellehmkuhl added the bug Something isn't working label Feb 16, 2024
@rafaellehmkuhl rafaellehmkuhl added this to the FromBetaToStable milestone Feb 16, 2024
@rafaellehmkuhl rafaellehmkuhl self-assigned this Feb 16, 2024
@pkmiles
Copy link

pkmiles commented Feb 16, 2024

hi @rafaellehmkuhl . I found this button a bit confusing to be honest.

The .webm and .ass files you see above this button: These are whats stored on the Raspberry Pi SSD, right? So on top of that is there a temp video cache storage as a seperate thing, before they get written to the SSD (?) and that button clears it(?).

If above statement TRUE:

  1. When would a user need to do this? i.e. is it a routine activity or something you'd do when something goes wrong/gets stuck.
  2. If so i'd say that's kind of a nuts-and-bolts exception feature and should be in "advanced" and hidden on the page with a bit more of a description on when and why you should use it.

If above statement FALSE (and Temp Video Cache = SSD storage of .webm and .ass files):

  1. Then maybe look at simplifying the language around this: "Device Storage" or "Local Storage" something like that?

I think as soon as you start using the word "cache" in a user interface you're potentially losing a non-technical audience (lol) What do you think?. Actually button says "Clear temporary video storage"... But I would expect that to delete all the files... because I don't see what temporary video storage is vs. what's showing in the file list above (that feels temporary too).

@rafaellehmkuhl
Copy link
Member Author

Answering in parts:

  1. Both the .webm and .ass files are stores on the disk of your topside computer. We currently don't use the vehicle storage for that, although we plan to (Store video recording on the vehicle instead of the top-side computer #719). The difference between the .webm/.ass files available there and the temporary files (mentioned by the button) is that the former are final files to be read by a video player, while the latter are video chunks of about 1 second that are stored during recording and merged on a single file when you click to stop the recording.

  2. The user should use this button regularly, to prevent unwanted usage of disk space, and this is not done automatically today so we can try to recover from failed videos when they happen during this beta phase. We still have to decide if we are going to keep it there or just do that automatically once we reach stable.

  3. Totally agree.

So, in the end, we still have to decide on what to do with this button, but your suggestion of putting it on an advanced mode is good.

We also have to add the option for the user to download those temporary files for the cases of video recovery, like you reported on #741. I commented about it more there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants