Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joystick: account for pilot input failsafes #717

Open
ES-Alexander opened this issue Feb 1, 2024 · 0 comments
Open

Joystick: account for pilot input failsafes #717

ES-Alexander opened this issue Feb 1, 2024 · 0 comments
Labels
enhancement New feature or request safety ux Has to do with the user experience

Comments

@ES-Alexander
Copy link
Contributor

ES-Alexander commented Feb 1, 2024

Extension of #713, to avoid accidentally causing a failsafe while also avoiding needless resource wastage:

An ideal solution would account for whether there is a pilot input failsafe configured, and if so send repeated inputs only as often as necessitated by the timeout parameter (to minimise resource wastage). That said, I'm not sure whether non-ArduSub vehicles actually have such a failsafe - could be good to check that, and/or offer the repeated message frequency as a user-configurable parameter.

ArduSub has FS_PILOT_INPUT, with times managed by FS_PILOT_TIMEOUT.

Rover has RC_FS_TIMEOUT, although we should check whether this applies to MANUAL_CONTROL (and RC_CHANNELS_OVERRIDE, for future reference), or if it only applies to real RC input.

Haven't checked other vehicle firmwares, and it's probably worth supporting a manual override in Cockpit since we can't guarantee all vehicles will have such a parameter for a timeout.


NOTE: autopilot handling of no pilot input is generally separate to how it handles completely losing connection to the control station software (e.g. triggered via a heartbeat/gcs failsafe, like GCS_FS_ENABLE).

@ES-Alexander ES-Alexander added enhancement New feature or request ux Has to do with the user experience safety labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request safety ux Has to do with the user experience
Projects
None yet
Development

No branches or pull requests

1 participant