Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button commands maybe leaking? We need manual-control logs! #816

Open
rafaellehmkuhl opened this issue Mar 9, 2024 · 1 comment · May be fixed by #1483
Open

Button commands maybe leaking? We need manual-control logs! #816

rafaellehmkuhl opened this issue Mar 9, 2024 · 1 comment · May be fixed by #1483
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers investigate safety

Comments

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Mar 9, 2024 •
edited
Loading

Reported by Kurt:

When I activate the light controls to turn on the lumen lights, on the fifth button press the newton gripper activates. I can continue turning up the lights to 100%, then turning them down, on the fifth button press the newton gripper activates again. The gripper works fine when I use the buttons that are configured for controlling it.

It can be a hardware-related problem, but I think we should at least add more logging to the manual-control pipeline, so we could confirm Cockpit is not sending wrong commands.
@rafaellehmkuhl rafaellehmkuhl changed the title Button commands maybe leaking? We need manual-control logs Button commands maybe leaking? We need manual-control logs! Mar 9, 2024
@rafaellehmkuhl rafaellehmkuhl added good first issue Good for newcomers investigate safety bug Something isn't working enhancement New feature or request labels Mar 9, 2024
@ES-Alexander
Copy link
Contributor

While I think it's generally useful for Cockpit to be able to log everything that comes in and goes out (especially MAVLink comms, per #451), this issue in particular should be effectively covered by the autopilot's logs, and the flight controller's servo output values can be viewed live via the SERVO_OUTPUT_RAW MAVLink message, including in VeryGenericIndicator mini-widgets within Cockpit itself:

Screenshot 2024-03-16 at 12 13 46 am

@rafaellehmkuhl rafaellehmkuhl linked a pull request Dec 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers investigate safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MAVLink inspection tool rafaellehmkuhl/cockpit-public
2 participants
@rafaellehmkuhl @ES-Alexander