Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

Only supports primitive message fields? #43

Open
ctoomey opened this issue Jan 25, 2020 · 2 comments
Open

Only supports primitive message fields? #43

ctoomey opened this issue Jan 25, 2020 · 2 comments

Comments

@ctoomey
Copy link

ctoomey commented Jan 25, 2020

I'm attempting to use this in a source connector to convert from connect format to protobuf and am getting an Unknown schema type: STRUCT exception when it's trying to convert a google.protobuf.Int32Value field. Poking around in the source code I see it doesn't handle any complex field types (map, array, struct).

Was this just because you haven't needed that for your protobuf messages and so haven't implemented that support yet, or is there some other reason you haven't done it?

@tinder-dthomson
Copy link

@ctoomey This is the reason why we don't use this converter. It doesn't handle the most basic STRUCTS. If you're doing any CDC which has a before and after schema, this won't work for you. This converter needs love.

@blacktooth
Copy link

+1, Is this being worked on?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants