Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

Support for camelCase #30

Open
darwinbeard opened this issue Nov 13, 2019 · 3 comments
Open

Support for camelCase #30

darwinbeard opened this issue Nov 13, 2019 · 3 comments

Comments

@darwinbeard
Copy link

darwinbeard commented Nov 13, 2019

Currently, kafka-connect-protobuf-converter converts proto messages to the object with keys in snake_case.

It happens on line 71:
https://github.com/blueapron/kafka-connect-protobuf-converter/blob/master/src/main/java/com/blueapron/connect/protobuf/ProtobufData.java#L71
String name = descriptor.getName();

Having an option that toggles between snake_case and camelCase would be great.

Changing line 71 mentioned above to:
String name = descriptor.getJsonName();
does it functionality; however, breaks a lot of tests.

@normzeng
Copy link
Contributor

@darwinbeard If this is still an issue, please open a pull request and I can approve, otherwise, please close!

@ebbnflow
Copy link

I'm working on this feature. I'll submit a PR when ready.

@malthe
Copy link

malthe commented Feb 21, 2023

@ebbnflow any update?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants