-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: rename project to rockervsc #3
Conversation
Reviewer's Guide by SourceryThis pull request renames the project from 'python_template' to 'rockervsc'. The changes are implemented by updating the project name in various files throughout the repository, including configuration files, documentation, and source code. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blooop - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded token found in Codecov badge URL. (link)
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
||
# change project name in all files | ||
find . \( -type d -name .git -prune \) -o \( -type f -not -name 'tasks.json' -not -name 'update_from_template.sh' \) -print0 | xargs -0 sed -i "s/python_template/$1/g" | ||
find . \( -type d -name .git -prune \) -o \( -type f -not -name 'tasks.json' -not -name 'update_from_template.sh' \) -print0 | xargs -0 sed -i "s/rockervsc/$1/g" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider improving the sed command to handle case variations in project name replacement
The current sed command only replaces exact matches of the project name. To make it more robust, you could use case-insensitive matching or include variations of the project name (e.g., uppercase, lowercase, camel case). This would ensure all instances of the project name are replaced, regardless of their case.
find . \( -type d -name .git -prune \) -o \( -type f -not -name 'tasks.json' -not -name 'update_from_template.sh' \) -print0 | xargs -0 sed -i "s/rockervsc/$1/g" | |
find . \( -type d -name .git -prune \) -o \( -type f -not -name 'tasks.json' -not -name 'update_from_template.sh' \) -print0 | xargs -0 sed -i -E "s/rockervsc/$1/gI; s/rocker[_-]?vsc/$1/gI; s/[Rr]ocker[Vv][Ss][Cc]/$1/g" |
README.md
Outdated
[![GitHub release](https://img.shields.io/github/release/blooop/python_template.svg)](https://GitHub.com/blooop/python_template/releases/) | ||
[![License](https://img.shields.io/github/license/blooop/python_template)](https://opensource.org/license/mit/) | ||
[![Ci](https://github.com/blooop/rockervsc/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/blooop/rockervsc/actions/workflows/ci.yml?query=branch%3Amain) | ||
[![Codecov](https://codecov.io/gh/blooop/rockervsc/branch/main/graph/badge.svg?token=Y212GW1PG6)](https://codecov.io/gh/blooop/rockervsc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Hardcoded token found in Codecov badge URL.
The token 'Y212GW1PG6' appears to be hardcoded in the Codecov badge URL. Consider using an environment variable or a secure method to handle this token.
Summary by Sourcery
Rename the project from 'python_template' to 'rockervsc' throughout the codebase, including documentation, configuration files, scripts, and code imports.
Enhancements:
Documentation: