Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove expiration time picker #545

Merged
merged 12 commits into from
Aug 31, 2023
Merged

feat: remove expiration time picker #545

merged 12 commits into from
Aug 31, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Aug 31, 2023

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi changed the title Feat/remove expiration time picker feat: remove expiration time picker Aug 31, 2023
@MarkNerdi MarkNerdi marked this pull request as ready for review August 31, 2023 11:33
MarkNerdi
MarkNerdi previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi MarkNerdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MarkNerdi
MarkNerdi approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi MarkNerdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi MarkNerdi merged commit 0ba2e7e into develop Aug 31, 2023
4 checks passed
@MarkNerdi MarkNerdi deleted the feat/remove-expiration-time-picker branch August 31, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi MarkNerdi MarkNerdi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tuditi @MarkNerdi