Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ExpirationTimePicker #542

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: ExpirationTimePicker #542

merged 2 commits into from
Aug 31, 2023

Conversation

jeeanribeiro
Copy link
Member

Summary

Tooltip was missing as wrapper for DateTimePicker

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Aug 31, 2023
@jeeanribeiro jeeanribeiro changed the title fix: expiration time picker fix: ExpirationTimePicker Aug 31, 2023
Tuditi
Tuditi approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit 8edc45d into develop Aug 31, 2023
4 checks passed
@Tuditi Tuditi deleted the fix/expiration-time-picker branch August 31, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@jeeanribeiro jeeanribeiro

Labels
type:fix
Projects
Bloom - Task Management
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeeanribeiro @Tuditi