-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: polish multichain Transak upgrade #2788
Merged
nicole-obrien
merged 19 commits into
2590----create-buysell-exchange-ui
from
2785-polish-multichain-transak-upgrade
Aug 13, 2024
Merged
chore: polish multichain Transak upgrade #2788
nicole-obrien
merged 19 commits into
2590----create-buysell-exchange-ui
from
2785-polish-multichain-transak-upgrade
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltichain-transak-upgrade
nicole-obrien
requested review from
cvarley100 and
nicole-obrien
as code owners
August 13, 2024 14:44
nicole-obrien
approved these changes
Aug 13, 2024
nicole-obrien
merged commit Aug 13, 2024
08bcd28
into
2590----create-buysell-exchange-ui
10 checks passed
jeeanribeiro
added a commit
that referenced
this pull request
Aug 14, 2024
* feat: adds MVP exchange screen in buy/sell view * feat: adds multichain support in Buy/Sell view (#2725) * feat: adds multichain support in BuySell view * refactor: use network id on transak cryptocurrency Co-authored-by: Jean Ribeiro <[email protected]> * use id in token popup filter * enable buy sell on all profiles * add network into transak crypto currencies * dynamically pull in transak cryptos based of profile networks * enhancment: sort transak cryptos --------- Co-authored-by: Nicole O'Brien <[email protected]> * fix: ui polish * fix: select token popup changing store * feat: adds icon and skeleton loading in cryptocurrency tile * feat: adds getPrice function * feat: add quotes panel in buy/sell view (#2739) * WIP * chore: fix reactivity and organize code * chore: fix selected cryptocurrency & increase exchange panel height * feat: add RecipientInput --------- Co-authored-by: Nicole O'Brien <[email protected]> * feat: Transak window as a Popup (#2743) * feat: Transak window as a Popup * refactor: change TransakConnectionPanel to be a popup banner * fix: disable button if necessary * fix: adds locale strings in quotations panel * fix: makes TransakFramePopup props optional * enhancement: sets error to true if any of the props in falsy * feat: buy/sell quotations timer (#2753) * feat: adds buy/sell quotations timer * fix: quote timer logic Co-authored-by: Jean Ribeiro <[email protected]> * refactor: cleanup quote loading state --------- Co-authored-by: Nicole O'Brien <[email protected]> * feat: adds selectable quotation and dynamic text (#2759) Co-authored-by: Nicole O'Brien <[email protected]> * feat: localise payment methods, improve icons and fix iframe width/border (#2760) * enhancement: adds payment methods localization * fix: remove array of undefined in quotes * fix: getComputedStyle error and iframe out of bounds * chore: update bloom ui kit version --------- Co-authored-by: Nicole O'Brien <[email protected]> * enhancement: auto select first quotation * feat: adds min and max amount in TransakAmountInput (#2761) * feat: adds min and max amount in TransakAmountInput * fix: logic so that no quotes are generated when value is outside min or max Co-authored-by: Jean Ribeiro <[email protected]> --------- Co-authored-by: Nicole O'Brien <[email protected]> * chore: polish multichain Transak upgrade (#2788) * fix: only show currencies that have payment method available * feat: adds TransakCryptoCurrencyTile variant * feat: adds view title * feat: adds colors to tokens network pills * fix: prevent selected currency option undefined error * feat: adds EmptyListPlaceholder in TransakExchangePanel * refactor: uses transak api base url depending on profile network * fix: undefined currency * feat: adds transak widget url for testnet and mainnet * fix: quotations positioning * feat: updates ui kit and adds Pill colors * chore: inverts TransakCryptoCurrencyAmountTile amounts position * refactor: create network name pill component * ui: fix transak frame height * refactor: organise transak query params, enable transak menu * refactor: rename transak quotation tile * fix: iota showing on buy sell for mainnet profiles * ui: dont capitalise names on network pill --------- Co-authored-by: Nicole O'Brien <[email protected]> --------- Co-authored-by: Nicole O'Brien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #2785
Testing
Platforms
Checklist