Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add coingecko token images to be loaded in CSP #2547

Merged
merged 4 commits into from
May 28, 2024
Merged

fix: add coingecko token images to be loaded in CSP #2547

merged 4 commits into from
May 28, 2024

Conversation

jeeanribeiro
Copy link
Member

Summary

closes #2545

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this May 25, 2024
@jeeanribeiro jeeanribeiro linked an issue May 25, 2024 that may be closed by this pull request
️🛠 - Allow token icons from coingecko to be loaded #2545
Closed
@jeeanribeiro jeeanribeiro changed the title fix: add coingecko token images to be loaded fix: add coingecko token images to be loaded in CSP May 25, 2024
Tuditi
Tuditi requested changes May 27, 2024
View reviewed changes
packages/desktop/public/index.html Outdated Show resolved Hide resolved
@Tuditi Tuditi enabled auto-merge (squash) May 28, 2024 08:01
@Tuditi Tuditi merged commit ce3ff9b into develop May 28, 2024
7 checks passed
@Tuditi Tuditi deleted the 2545-allow-token-icons-from-coingecko-to-be-loaded branch May 28, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@jeeanribeiro jeeanribeiro

Labels
type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Allow token icons from coingecko to be loaded
2 participants
@jeeanribeiro @Tuditi