Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support one click dapp connection and sign in #2543

Merged

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this May 24, 2024
@MarkNerdi MarkNerdi linked an issue May 24, 2024 that may be closed by this pull request
@MarkNerdi MarkNerdi force-pushed the 2476----support-one-click-dapp-connection-and-sign-in branch 2 times, most recently from c598164 to 788e77e Compare May 24, 2024 12:22
@MarkNerdi MarkNerdi requested a review from nicole-obrien May 27, 2024 09:33
@MarkNerdi MarkNerdi marked this pull request as ready for review May 27, 2024 09:33
@MarkNerdi MarkNerdi requested a review from cvarley100 as a code owner May 27, 2024 09:33
@MarkNerdi MarkNerdi marked this pull request as draft May 30, 2024 06:47
@MarkNerdi MarkNerdi force-pushed the 2476----support-one-click-dapp-connection-and-sign-in branch from 5b88aa7 to 109aac8 Compare May 31, 2024 12:00
@nicole-obrien nicole-obrien marked this pull request as ready for review May 31, 2024 13:44
@nicole-obrien nicole-obrien enabled auto-merge (squash) June 26, 2024 09:35
@nicole-obrien nicole-obrien merged commit 25c3e22 into develop Jun 26, 2024
7 checks passed
@nicole-obrien nicole-obrien deleted the 2476----support-one-click-dapp-connection-and-sign-in branch June 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Support one click dapp connection and sign in
2 participants