enhancement: uses VirtualList in notifications #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent/notifications-virtual-list
MarkNerdi
approved these changes
May 24, 2024
nicole-obrien
added a commit
that referenced
this pull request
Jun 12, 2024
* feat: add walletconnect notify api (#2512) * initialize notify client * notify client store * register and subscribe to notifications * implement test subscription * improve initialization * subscribe to gm walletconnect * create notify manager class Co-authored-by: Nicole O'Brien <[email protected]> Co-authored-by: Tuditi <[email protected]> * set notifications to store * update yarn lock * initialize notifications and subscriptions Co-authored-by: Tuditi <[email protected]> Co-authored-by: Nicole O'Brien <[email protected]> * cleanup handlers Co-authored-by: Tuditi <[email protected]> Co-authored-by: Nicole O'Brien <[email protected]> Co-authored-by: Jean Ribeiro <[email protected]> --------- Co-authored-by: Nicole O'Brien <[email protected]> Co-authored-by: Tuditi <[email protected]> Co-authored-by: Jean Ribeiro <[email protected]> * chore: cleanup notification manager init (#2513) * cleanup notification manager initialization Co-authored-by: Nicole O'Brien <[email protected]> * add message handler --------- Co-authored-by: Nicole O'Brien <[email protected]> * fix: fix notify client (#2516) * fix notify client initialize * fix dependencies Co-authored-by: Jean Ribeiro <[email protected]> --------- Co-authored-by: Jean Ribeiro <[email protected]> * feat: add notification components (#2514) * WIP * improve notification popup * use dapp icon as main image * add small badge * add notificationavatar * only show fixed amount + add localizations Co-authored-by: Jean Ribeiro <[email protected]> * add time test * cleanup --------- Co-authored-by: Jean Ribeiro <[email protected]> * feat: adds Link in NotificationTile (#2528) * feat: highlight unread notifications (#2527) * chore: refactor for multi chain support (#2511) * chore: remove BASE_TOKEN_CONTRACT_ADDRESS map * chore: rename getL1Network to getStardustNetwork * fix: type * feat: highlight unread notification * fix incoming notifications * restructure --------- Co-authored-by: Tuditi <[email protected]> Co-authored-by: Mark Nardi <[email protected]> * feat: mark notification as read if visible (#2532) * fix: removes view all button and show all notifications in dropdown * feat: mark notifications as read if visible * chore: update @bloomwalletio/ui * fix: updates notifications store only after closing the dropdown * decrease threshold --------- Co-authored-by: Mark Nardi <[email protected]> * fix: type errors * feat: notifications unread tab (#2540) * feat: notifications unread tab * add optional chain --------- Co-authored-by: Mark Nardi <[email protected]> * enhancement: uses VirtualList in notifications (#2541) * enhancement: uses VirtualList in notifications * fix merge issue --------- Co-authored-by: Mark Nardi <[email protected]> * cleanup * feat: notification details popup (#2554) * show basetoken amount on smartcontract popups (#2549) * feat: adds notification details popup Co-authored-by: Mark Nardi <[email protected]> Co-authored-by: Nicole O'Brien <[email protected]> Co-authored-by: Tuditi <[email protected]> * fix: PopupComponentMap type --------- Co-authored-by: Mark Nardi <[email protected]> Co-authored-by: Nicole O'Brien <[email protected]> Co-authored-by: Tuditi <[email protected]> * fix linter * fix: notification read state Co-authored-by: Mark Nardi <[email protected]> * polish nav bar with notification button * split notification components * remove notification tabs * enable notifications for multiple networks * fix notifications initialization * improve siwe validation check * fix: notification tile hover * fix: popover closing behaviour for notifications * ui: empty placeholder in notifications * enable notifications in network drawer * fix notification toggle state * improve notification registering Co-authored-by: Mark Nardi <[email protected]> * register for notifications on some generate addresses * register account on evm address generation * only register if not registered * fix login if account is unregistered * Fix notification registration on onboarding Co-authored-by: Nicole O'Brien <[email protected]> * remove mulitple instances of notifiation body * WIP * fix: whitelist notification links * fix tracked address initialization * remove console logs * ui: polish notification details popup Co-authored-by: Mark Nardi <[email protected]> * ui: polish notification tile * improve logic in complete onboarding Co-authored-by: Mark Nardi <[email protected]> * chore: fix formatting --------- Co-authored-by: Nicole O'Brien <[email protected]> Co-authored-by: Tuditi <[email protected]> Co-authored-by: Jean Ribeiro <[email protected]> Co-authored-by: Tuditi <[email protected]> Co-authored-by: Nicole O'Brien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes possible to render a huge list of notifications
Testing
Platforms
Checklist