Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

️🛠 - Remove actions and store exports from layer-2 module #521

Closed
nicole-obrien opened this issue Aug 29, 2023 · 0 comments · Fixed by #522
Closed

️🛠 - Remove actions and store exports from layer-2 module #521

nicole-obrien opened this issue Aug 29, 2023 · 0 comments · Fixed by #522
Assignees
@nicole-obrien
Labels
type:refactor
Milestone
E0X.M02 - Softwar...

Comments

@nicole-obrien
Copy link
Contributor

Task description

Due to circular imports we limit accessing stores in the actions and stores sub folders only. Therefore we need to remove these exports at the top level of the module so that they are accessed more direct and not pulled in by other barrel imports.
We should also check that the utils does not contain any actions.

Requirements

  • Move actions to utils
  • Remove actions and store exports
  • Update imports
@nicole-obrien nicole-obrien moved this from 📋 Backlog to 🔖 Todo in Bloom - Task Management Aug 29, 2023
@nicole-obrien nicole-obrien self-assigned this Aug 29, 2023
@nicole-obrien nicole-obrien moved this from 🔖 Todo to 🏗 In Progress in Bloom - Task Management Aug 29, 2023
@nicole-obrien nicole-obrien linked a pull request Aug 29, 2023 that will close this issue
refactor: organise imports and exports in layer-2 module #522
Merged
10 tasks
@nicole-obrien nicole-obrien moved this from 🏗 In Progress to 👀 Needs Review in Bloom - Task Management Aug 29, 2023
@github-project-automation github-project-automation bot moved this from 👀 Needs Review to 🎉 Done in Bloom - Task Management Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicole-obrien nicole-obrien

Labels
type:refactor
Projects
Bloom - Task Management
Archived in project
Milestone
E0X.M02 - Software Quality Improvements
Development

Successfully merging a pull request may close this issue.

refactor: organise imports and exports in layer-2 module bloomwalletio/bloom
1 participant
@nicole-obrien