Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

️🛠 - Don't allow infinite approvals for erc20 tokens #2628

Closed
nicole-obrien opened this issue Jun 17, 2024 · 0 comments · Fixed by #2718
Closed

️🛠 - Don't allow infinite approvals for erc20 tokens #2628

nicole-obrien opened this issue Jun 17, 2024 · 0 comments · Fixed by #2718
Assignees
@MarkNerdi
Labels
type:enhancement
Milestone
E02.M08 - Advance...

Comments

@nicole-obrien
Copy link
Contributor

Task description

We should not allow dapps to ask for infinite approvals. This is a security issue and dapps should ask for a specific amount or we allow the user to edit it after showing a warning. They can also bypass the warning if they want

Requirements

No response
@nicole-obrien nicole-obrien moved this from 📋 Backlog to 🔖 Todo in Bloom - Task Management Jun 19, 2024
@MarkNerdi MarkNerdi self-assigned this Jul 8, 2024
@MarkNerdi MarkNerdi moved this from 🔖 Todo to 🏗 In Progress in Bloom - Task Management Jul 8, 2024
@MarkNerdi MarkNerdi linked a pull request Jul 10, 2024 that will close this issue
refactor: cleanup evm transaction popup #2718
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to 🎉 Done in Bloom - Task Management Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkNerdi MarkNerdi

Labels
type:enhancement
Projects
Bloom - Task Management
Archived in project
Milestone
E02.M08 - Advanced L2 Token Support
2 participants
@MarkNerdi @nicole-obrien