Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

️🛠 - Add ethereum confirmed blocks property and derive confirmed state from it #2485

Closed
Tuditi opened this issue May 13, 2024 · 0 comments · Fixed by #2533
Closed

️🛠 - Add ethereum confirmed blocks property and derive confirmed state from it #2485

Tuditi opened this issue May 13, 2024 · 0 comments · Fixed by #2533
Assignees
@MarkNerdi @Tuditi
Labels
type:feature
Milestone
E02.M09 - Ethereu...

Comments

@Tuditi
Copy link
Contributor

Tuditi commented May 13, 2024 •
edited
Loading

Task description

We need to distinguish confirmed/non-confirmed blocks on Ethereum. To become confirmed a transaction must have a threshold confirmed blocks (e.g. 6) after its own block. Therefor we need to have the same behavior as on L1

Pending Activity contains a property of e.g. 2/6 confirmations, where 2 is the amount of confirmed blocks and 6 the threshold.
Confirmed Activity contains just a text that states confirmed

Add a pill with confirmed/unconfirmed

Requirements
@Tuditi Tuditi moved this from 📋 Backlog to 🔖 Todo in Bloom - Task Management May 13, 2024
@Tuditi Tuditi moved this from 🔖 Todo to 🚫 Blocked in Bloom - Task Management May 13, 2024
@Tuditi Tuditi added this to the E02.M09 - EVM Network support milestone May 13, 2024
@Tuditi Tuditi moved this from 🚫 Blocked to 🔖 Todo in Bloom - Task Management May 13, 2024
@Tuditi Tuditi moved this from 🔖 Todo to 🏗 In Progress in Bloom - Task Management May 23, 2024
@Tuditi Tuditi linked a pull request May 23, 2024 that will close this issue
feat: add ethereum confirmed blocks property #2533
Merged
10 tasks
@Tuditi Tuditi mentioned this issue May 23, 2024
Merged
10 tasks
@MarkNerdi MarkNerdi moved this from 🏗 In Progress to 👀 Needs Review in Bloom - Task Management May 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 Needs Review to 🎉 Done in Bloom - Task Management May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkNerdi MarkNerdi

@Tuditi Tuditi

Labels
type:feature
Projects
Bloom - Task Management
Archived in project
Milestone
E02.M09 - Ethereum Mainnet Support
Development

Successfully merging a pull request may close this issue.

feat: add ethereum confirmed blocks property bloomwalletio/bloom
2 participants
@MarkNerdi @Tuditi