Skip to content

Commit

Permalink
try disabling electron builder notarize
Browse files Browse the repository at this point in the history
  • Loading branch information
nicole-obrien committed Oct 12, 2023
1 parent 01c4b27 commit e703875
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/reusable_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ jobs:
CSC_KEY_PASSWORD: ${{ secrets.APPLE_DEVELOPER_ID_APPLICATION_CERT_PASSWORD }}
CSC_INSTALLER_LINK: ${{ secrets.APPLE_DEVELOPER_ID_INSTALLER_CERT_BASE64 }}
CSC_INSTALLER_KEY_PASSWORD: ${{ secrets.APPLE_DEVELOPER_ID_INSTALLER_CERT_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
BLOOM_APPLE_ID: ${{ secrets.APPLE_ID }}
BLOOM_APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
MACOS_SKIP_NOTARIZATION: false
Expand Down
5 changes: 3 additions & 2 deletions packages/desktop/electron-builder-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ async function notarizeMacos(appBundleId, appName): Promise<void> {
return
}

const APPLE_ID = process.env.APPLE_ID
const APPLE_ID_PASSWORD = process.env.APPLE_ID_PASSWORD
const APPLE_ID = process.env.BLOOM_APPLE_ID
const APPLE_ID_PASSWORD = process.env.BLOOM_APPLE_ID_PASSWORD

if (!APPLE_ID) {
console.log('Notarization - failed: Environment variable "BLOOM_APPLE_ID" is not defined')
Expand Down Expand Up @@ -160,6 +160,7 @@ const prodConfig: Configuration = {
entitlementsInherit: './entitlements.mac.plist',
hardenedRuntime: true,
gatekeeperAssess: false,
notarize: false,
asarUnpack: ['**/*.node'],
},
publish: {
Expand Down

0 comments on commit e703875

Please sign in to comment.