fix: remove duplicated ownership check (#2393)

* filter for network on ownership check * disable feature flag
bloomwalletio · Apr 29, 2024 · a5681bc · a5681bc
1 parent 0ba5be6
commit a5681bc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/desktop/features/network.features.ts b/packages/desktop/features/network.features.ts
@@ -12,7 +12,7 @@ const networkFeatures: INetworkFeatures = {
         },
     },
     evmNetworks: {
-        enabled: true,
+        enabled: false,
     },
 }
 

diff --git a/packages/shared/src/lib/core/layer-2/actions/fetchL2BalanceForAccount.ts b/packages/shared/src/lib/core/layer-2/actions/fetchL2BalanceForAccount.ts
@@ -23,7 +23,7 @@ export function fetchL2BalanceForAccount(profileId: string, account: IAccountSta
         }
 
         if (features.collectibles.erc721.enabled) {
-            void updateErc721NftsOwnership(account)
+            void updateErc721NftsOwnership(account, evmNetwork.id)
         }
 
         const l2TokenBalance = isIscChain(evmNetwork)

diff --git a/packages/shared/src/lib/core/nfts/actions/updateErc721NftOwnership.ts b/packages/shared/src/lib/core/nfts/actions/updateErc721NftOwnership.ts
@@ -5,12 +5,13 @@ import { IErc721Nft } from '../interfaces'
 import { getAllAccountNfts, persistedNftForActiveProfile, updatePersistedNft } from '../stores'
 import { getOwnerOfErc721Nft } from '../utils'
 import { get } from 'svelte/store'
+import { NetworkId } from '@core/network'
 
-export async function updateErc721NftsOwnership(account: IAccountState): Promise<void> {
+export async function updateErc721NftsOwnership(account: IAccountState, networkId: NetworkId): Promise<void> {
     try {
         const trackedErc721Nfts =
             (getAllAccountNfts()[account.index]?.filter((nft) => {
-                return nft.standard === NftStandard.Erc721
+                return nft.standard === NftStandard.Erc721 && nft.networkId === networkId
             }) as IErc721Nft[]) ?? []
         const promises = trackedErc721Nfts.map(async (nft) => {
             const updatedOwner = await getOwnerOfErc721Nft(nft)
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,7 +12,7 @@ const networkFeatures: INetworkFeatures = { @@
             },
         },
         evmNetworks: {
-            enabled: true,
+            enabled: false,
         },
     }
@@ Expand Down @@