From 10cbd1683265a75456fff66f216948c036e23ba2 Mon Sep 17 00:00:00 2001
From: Mark Nardi <nardimark7@gmail.com>
Date: Fri, 5 Jul 2024 12:09:23 +0200
Subject: [PATCH] enhancement: warn about approvals for tokens that are not
 currently held (#2711)

* add warning to approval popup

* add locale
---
 .../components/evm-transactions/EvmTokenApprovalAlert.svelte    | 2 ++
 packages/shared/src/locales/en.json                             | 1 +
 2 files changed, 3 insertions(+)

diff --git a/packages/desktop/components/evm-transactions/EvmTokenApprovalAlert.svelte b/packages/desktop/components/evm-transactions/EvmTokenApprovalAlert.svelte
index 945a7d712e..ef24191d65 100644
--- a/packages/desktop/components/evm-transactions/EvmTokenApprovalAlert.svelte
+++ b/packages/desktop/components/evm-transactions/EvmTokenApprovalAlert.svelte
@@ -9,6 +9,7 @@
     import { EvmTransactionAlert } from '.'
     import { IToken } from '@core/token'
     import { openUrlInBrowser } from '@core/app/utils'
+    import { Alert } from '@bloomwalletio/ui'
 
     export let parsedTokenApproval: IParsedTokenApproval
     export let networkId: EvmNetworkId
@@ -37,6 +38,7 @@
     {#if tokenTransfer.token}
         <TransactionAssetSection {tokenTransfer} />
     {:else}
+        <Alert variant="warning" text={localize('popups.tokenApproval.warning')} />
         <Table
             collapsible
             collapsibleTitle={localize('general.details')}
diff --git a/packages/shared/src/locales/en.json b/packages/shared/src/locales/en.json
index a45f391286..c546045489 100644
--- a/packages/shared/src/locales/en.json
+++ b/packages/shared/src/locales/en.json
@@ -1111,6 +1111,7 @@
         "tokenApproval": {
             "title": "Approve {dappName} to access {assetName}",
             "hint": "{address} is requesting approval to spend {assetName}",
+            "warning": "You don't own any of the approved tokens. Only approve tokens you trust.",
             "action": "Approve",
             "success": "Successfully approved"
         },