diff --git a/src/groups/bmq/bmqtsk/bmqtsk_alarmlog.h b/src/groups/bmq/bmqtsk/bmqtsk_alarmlog.h index a597255b1..f6fab181b 100644 --- a/src/groups/bmq/bmqtsk/bmqtsk_alarmlog.h +++ b/src/groups/bmq/bmqtsk/bmqtsk_alarmlog.h @@ -209,6 +209,14 @@ class AlarmLog : public ball::ObserverAdapter { /// will be dumped to stderr with respects to rate-controlled logic. void publish(const ball::Record& record, const ball::Context& context) BSLS_KEYWORD_OVERRIDE; + + /// Note: this member is overriden to get rid of the "hides the virtual + /// function" warning. + inline void publish(const bsl::shared_ptr& record, + const ball::Context& context) BSLS_KEYWORD_OVERRIDE + { + publish(*record, context); + } }; } // close package namespace diff --git a/src/groups/bmq/bmqtsk/bmqtsk_consoleobserver.h b/src/groups/bmq/bmqtsk/bmqtsk_consoleobserver.h index 472727ad1..0162f6cc7 100644 --- a/src/groups/bmq/bmqtsk/bmqtsk_consoleobserver.h +++ b/src/groups/bmq/bmqtsk/bmqtsk_consoleobserver.h @@ -239,6 +239,14 @@ class ConsoleObserver : public ball::ObserverAdapter { void publish(const ball::Record& record, const ball::Context& context) BSLS_KEYWORD_OVERRIDE; + /// Note: this member is overriden to get rid of the "hides the virtual + /// function" warning. + inline void publish(const bsl::shared_ptr& record, + const ball::Context& context) BSLS_KEYWORD_OVERRIDE + { + publish(*record, context); + } + // ACCESSORS /// Return the currently set severity threshold of this object. diff --git a/src/groups/bmq/bmqtsk/bmqtsk_syslogobserver.h b/src/groups/bmq/bmqtsk/bmqtsk_syslogobserver.h index 7ae9adbde..489b3b425 100644 --- a/src/groups/bmq/bmqtsk/bmqtsk_syslogobserver.h +++ b/src/groups/bmq/bmqtsk/bmqtsk_syslogobserver.h @@ -166,6 +166,14 @@ class SyslogObserver : public ball::ObserverAdapter { void publish(const ball::Record& record, const ball::Context& context) BSLS_KEYWORD_OVERRIDE; + /// Note: this member is overriden to get rid of the "hides the virtual + /// function" warning. + inline void publish(const bsl::shared_ptr& record, + const ball::Context& context) BSLS_KEYWORD_OVERRIDE + { + publish(*record, context); + } + // ACCESSORS /// Return the currently set severity threshold of this object. diff --git a/src/groups/bmq/bmqtst/bmqtst_scopedlogobserver.h b/src/groups/bmq/bmqtst/bmqtst_scopedlogobserver.h index bb298ae86..6a778cd73 100644 --- a/src/groups/bmq/bmqtst/bmqtst_scopedlogobserver.h +++ b/src/groups/bmq/bmqtst/bmqtst_scopedlogobserver.h @@ -145,6 +145,14 @@ class ScopedLogObserver : public ball::ObserverAdapter { void publish(const ball::Record& record, const ball::Context& context) BSLS_KEYWORD_OVERRIDE; + /// Note: this member is overriden to get rid of the "hides the virtual + /// function" warning. + inline void publish(const bsl::shared_ptr& record, + const ball::Context& context) BSLS_KEYWORD_OVERRIDE + { + publish(*record, context); + } + public: // ACCESSORS diff --git a/src/groups/bmq/bmqu/bmqu_blobiterator.h b/src/groups/bmq/bmqu/bmqu_blobiterator.h index 8c7afe485..68fc84757 100644 --- a/src/groups/bmq/bmqu/bmqu_blobiterator.h +++ b/src/groups/bmq/bmqu/bmqu_blobiterator.h @@ -135,11 +135,6 @@ class BlobIterator { /// referring to a valid value. const char& operator*() const; - /// Return a pointer to the byte being referred to by this - /// iterator. The behavior is undefined if this iterator isn't - /// referring to a valid value. - const char* operator->() const; - /// Return `true` if this `BlobIterator` has reached its end. bool atEnd() const; @@ -284,11 +279,6 @@ inline const char& BlobIterator::operator*() const return d_blob_p->buffer(d_pos.buffer()).data()[d_pos.byte()]; } -inline const char* BlobIterator::operator->() const -{ - return &**this; -} - inline bool BlobIterator::atEnd() const { return d_remaining <= 0; diff --git a/src/groups/mqb/mqbblp/mqbblp_domain.cpp b/src/groups/mqb/mqbblp/mqbblp_domain.cpp index 7f91b64b6..9955ff7f0 100644 --- a/src/groups/mqb/mqbblp/mqbblp_domain.cpp +++ b/src/groups/mqb/mqbblp/mqbblp_domain.cpp @@ -925,7 +925,7 @@ void Domain::removeDomainReset() bslmt::LockGuard guard(&d_mutex); // LOCK d_state = e_PREREMOVE; - d_teardownRemoveCb = nullptr; + d_teardownRemoveCb = bsl::nullptr_t(); } void Domain::removeDomainComplete() diff --git a/src/groups/mqb/mqbc/mqbc_clusterstate.cpp b/src/groups/mqb/mqbc/mqbc_clusterstate.cpp index e2763fc29..472e44d32 100644 --- a/src/groups/mqb/mqbc/mqbc_clusterstate.cpp +++ b/src/groups/mqb/mqbc/mqbc_clusterstate.cpp @@ -422,7 +422,7 @@ bool ClusterState::unassignQueue(const bmqt::Uri& uri) domIt->second->queuesInfo().erase(cit); if (domIt->second->queuesInfo().empty()) { - domIt->second->setDomain(nullptr); + domIt->second->setDomain(NULL); } // POSTCONDITIONS diff --git a/src/groups/mqb/mqbstat/mqbstat_brokerstats.h b/src/groups/mqb/mqbstat/mqbstat_brokerstats.h index 005e7c018..25feafb83 100644 --- a/src/groups/mqb/mqbstat/mqbstat_brokerstats.h +++ b/src/groups/mqb/mqbstat/mqbstat_brokerstats.h @@ -165,8 +165,7 @@ inline bmqst::StatContext* BrokerStats::statContext() } template <> -inline void -BrokerStats::onEvent() +inline void BrokerStats::onEvent() { BSLS_ASSERT_SAFE(d_statContext_p && "initialize was not called"); @@ -174,8 +173,7 @@ BrokerStats::onEvent() } template <> -inline void -BrokerStats::onEvent() +inline void BrokerStats::onEvent() { BSLS_ASSERT_SAFE(d_statContext_p && "initialize was not called"); @@ -183,8 +181,7 @@ BrokerStats::onEvent() } template <> -inline void -BrokerStats::onEvent() +inline void BrokerStats::onEvent() { BSLS_ASSERT_SAFE(d_statContext_p && "initialize was not called"); @@ -192,8 +189,7 @@ BrokerStats::onEvent() } template <> -inline void -BrokerStats::onEvent() +inline void BrokerStats::onEvent() { BSLS_ASSERT_SAFE(d_statContext_p && "initialize was not called"); diff --git a/src/groups/mqb/mqbstat/mqbstat_clusterstats.h b/src/groups/mqb/mqbstat/mqbstat_clusterstats.h index 3d7d5f78c..1707fb985 100644 --- a/src/groups/mqb/mqbstat/mqbstat_clusterstats.h +++ b/src/groups/mqb/mqbstat/mqbstat_clusterstats.h @@ -418,32 +418,28 @@ inline bmqst::StatContext* ClusterNodeStats::statContext() } template <> -inline void -ClusterNodeStats::onEvent( +inline void ClusterNodeStats::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { d_statContext_mp->adjustValue(ClusterNodeStatsIndex::e_STAT_ACK, 1); } template <> -inline void -ClusterNodeStats::onEvent( +inline void ClusterNodeStats::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { d_statContext_mp->adjustValue(ClusterNodeStatsIndex::e_STAT_CONFIRM, 1); } template <> -inline void -ClusterNodeStats::onEvent( +inline void ClusterNodeStats::onEvent( bsls::Types::Int64 value) { d_statContext_mp->adjustValue(ClusterNodeStatsIndex::e_STAT_PUSH, value); } template <> -inline void -ClusterNodeStats::onEvent( +inline void ClusterNodeStats::onEvent( bsls::Types::Int64 value) { d_statContext_mp->adjustValue(ClusterNodeStatsIndex::e_STAT_PUT, value); diff --git a/src/groups/mqb/mqbstat/mqbstat_domainstats.h b/src/groups/mqb/mqbstat/mqbstat_domainstats.h index 8f19a4d81..c57ae7bb7 100644 --- a/src/groups/mqb/mqbstat/mqbstat_domainstats.h +++ b/src/groups/mqb/mqbstat/mqbstat_domainstats.h @@ -157,7 +157,7 @@ inline bmqst::StatContext* DomainStats::statContext() } template <> -inline void DomainStats::onEvent( +inline void DomainStats::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -165,7 +165,7 @@ inline void DomainStats::onEvent( } template <> -inline void DomainStats::onEvent( +inline void DomainStats::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -173,7 +173,7 @@ inline void DomainStats::onEvent( } template <> -inline void DomainStats::onEvent( +inline void DomainStats::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); diff --git a/src/groups/mqb/mqbstat/mqbstat_queuestats.h b/src/groups/mqb/mqbstat/mqbstat_queuestats.h index d6fcd8e5b..ad3ae5869 100644 --- a/src/groups/mqb/mqbstat/mqbstat_queuestats.h +++ b/src/groups/mqb/mqbstat/mqbstat_queuestats.h @@ -527,8 +527,7 @@ inline bmqst::StatContext* QueueStatsDomain::statContext() } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -536,8 +535,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -545,8 +543,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -555,8 +552,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -566,7 +562,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -575,8 +571,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -586,7 +581,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -594,8 +589,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -603,8 +597,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -613,7 +606,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -631,7 +624,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -641,7 +634,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -649,8 +642,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( BSLS_ANNOTATION_UNUSED bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -670,7 +662,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -678,8 +670,7 @@ QueueStatsDomain::onEvent( } template <> -inline void -QueueStatsDomain::onEvent( +inline void QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -688,7 +679,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -697,7 +688,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called"); @@ -706,7 +697,7 @@ QueueStatsDomain::onEvent( template <> inline void -QueueStatsDomain::onEvent( +QueueStatsDomain::onEvent( bsls::Types::Int64 value) { BSLS_ASSERT_SAFE(d_statContext_mp && "initialize was not called");