Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal's "Close" button is cut off/ not visible on mobile devices #133

Closed
cade-exygy opened this issue Nov 1, 2023 · 1 comment
Closed
Assignees

Comments

@cade-exygy
Copy link
Collaborator

cade-exygy commented Nov 1, 2023

When testing the multiple listing images modal in DAHLIA on mobile devices, the modal's close button gets pushed down and is inaccessible.

Steps to reproduce:
On Mobile device:

Tested on

  • iOS Chrome and Safari
  • Android Firefox

Screenshot_20231025-152139

An important note: I am not seeing this issue when I go to storybook on mobile device: https://storybook.bloom.exygy.dev/?path=/story/blocks-image-card--four-images

Any advice would be appreciated!

QA Notes @cliu02 @cade-exygy:
Do you mind closing this ticket whenever you get the chance to verify that uptaking the new UI-C version resolves this issue?

@ColinBuyck
Copy link
Collaborator

We have experience fixing this sort of mobile issue! Check out this PR from Emily for more context. @sarahlazarich I believe we could use that PR as a model to fix this and it would be pretty straightforward.

@ColinBuyck ColinBuyck self-assigned this Nov 17, 2023
@cliu02 cliu02 closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants