Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override to version check to run in IDE with Client #246

Open
Dockter opened this issue Jul 31, 2020 · 1 comment
Open

Add override to version check to run in IDE with Client #246

Dockter opened this issue Jul 31, 2020 · 1 comment

Comments

@Dockter
Copy link

Dockter commented Jul 31, 2020

@bloodmc please consider adding this to your version check:

https://github.com/AlmuraDev/GriefPrevention/blob/master/src/main/java/me/ryanhamshire/griefprevention/GriefPreventionPlugin.java#L402

This allows me to run the mod as a plugin to the Almura client while in development mode.

@Dockter
Copy link
Author

Dockter commented Aug 3, 2020

I see you've started to add support for this; this is starting to load but stop during pre-init; likely because of this:

https://github.com/bloodmc/GriefDefender/blob/master/sponge/src/main/java/com/griefdefender/GriefDefenderPlugin.java#L545

Should probably not check either of those if de obfuscated environment detected. Also would be helpful if you could add some debug to that check so we can tell locally why the reason is doesn't load even if someone attempts to load this on the client in production mode (obfuscated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant