Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlineCustomMsgs not correctly added to websocket event #248

Open
liamaharon opened this issue May 31, 2019 · 2 comments
Open

inlineCustomMsgs not correctly added to websocket event #248

liamaharon opened this issue May 31, 2019 · 2 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@liamaharon
Copy link
Contributor

Encountered this while adding websocket-event validation on the server.

If I add some inlineCustomMsgs to my .send call, event.inlineCustomMsgs is received as {} on the backend. I would have expected the object to contain some info about the inline custom messages.

If I don't add inlineCustomMsgs to my .send calls, event.inlineCustomMsgs is undefined.

@cmeisl @aaronbarnardsound since this is a very non-breaking bug and Aaron will be rewriting the notifications library soon, is it a waste of time to debug? Otherwise let me know and I can spend some time digging into it.

(I'm using web3 v1)

@liamaharon liamaharon added bug Something isn't working question Further information is requested labels May 31, 2019
@lnbc1QWFyb24
Copy link
Collaborator

My guess is that the object is empty due to it being stringified before being logged and it isn't serializable? We should probably just take it off the event object that gets logged to the server as it isn't necessary to log it anyway.

@liamaharon
Copy link
Contributor Author

Yeah you're right, the values in the objects are all functions so not serializable. Makes sense to me to take them off the event object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants