Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spells.fyi - Support for zkSync Timelock Tracking #28

Open
calebsheridan opened this issue Jun 17, 2020 · 5 comments
Open

Spells.fyi - Support for zkSync Timelock Tracking #28

calebsheridan opened this issue Jun 17, 2020 · 5 comments
Labels
Gitcoin bounty Gitcoin bounty is available

Comments

@calebsheridan
Copy link
Member

calebsheridan commented Jun 17, 2020

Spells.fyi Subgraph Update

Spells.fyi is a public good tracking timelocked smart contract upgrades. This issue adds support for zkSync's timelock to the Spells.fyi subgraph.

Overview

zkSync offers a new type of timelock UpgradeGatekeeper which is an opt-out upgrade mechanism. From the docs:

A new upgrade must be announced via the zkSync contract and all users get 2 week notice period to exit in case they don't like the changes.

Contract

0x38A43F4330f24fe920F943409709fc9A6084C939

Notes

NoticePeriodStart is the name of the event that will be emitted at the start of upgrade.

Event parameters:

  • version
  • array of targets
  • notice period duration

Workflow

  • Add the contract to the subgraph manifest
  • Add the contract's ABI to the ABI folder
  • Add a mapping file for the contract with logging logic triggered by contract events to create/update:
  • New Timelock entity (see helpers)
  • New Platform entity (see helpers)
  • New Spell entity with required details (see schema)
  • New Target entities (see schema)
  • Update README
  • QA against example queries from README
@calebsheridan calebsheridan changed the title Support for zkSync Spells.fyi - Support for zkSync Jun 19, 2020
@calebsheridan calebsheridan changed the title Spells.fyi - Support for zkSync Spells.fyi - Support for zkSync Timelock Tracking Jun 19, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 20.0 DAI (20.0 USD @ $1.0/DAI) attached to it as part of the Blocklytics fund.

@calebsheridan calebsheridan added the Gitcoin bounty Gitcoin bounty is available label Jun 19, 2020
@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@iamonuwa
Copy link

@gitcoinbot work in progress

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 20.0 DAI (20.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin bounty Gitcoin bounty is available
Projects
None yet
Development

No branches or pull requests

3 participants