Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to change the gas amount instead of using the default #229

Open
antonellopasella-kedos opened this issue Mar 30, 2022 · 3 comments

Comments

@antonellopasella-kedos
Copy link
Contributor

I was thinking adding a parameter in the configuration to be able to change the default from etherscan to speed up the confirmation time.

We have these parameters
--tx_fee
--gas_price
--gas_limit

I'm proposing to add a "multiplier" to be used to change the default values

Is there any interest? Can I prepare a PR?

Design:

  • add two parameters called (my proposal) tx_fee_multiplier / gas_limit_multiplier
  • these parameters are multiplied to the original parameters (tx_fee/gas_limit) and the new values is used
@lemoustachiste
Copy link
Member

OK, so how would the multiplier come in play?
After a certain time, or by default? If by default then why not manually set the value?

@antonellopasella-kedos
Copy link
Contributor Author

I was thinking by default.
I won't set manually the value because I have to check the current gas fee before calling the issuer and, then, set the command line param.

If today the fee is 40 and tomorrow will be 50, I want to be 44 and 55 (+10%) automatically to have a faster confirmation, without have any call (with other libraries) in the script calling the issuer.

@lemoustachiste
Copy link
Member

So I believe it's not a bad idea, but basically you would manually check the current gas fee, and use that multiplier to adjust the base value to the current prices? So instead of modifying 3 values, changing just one?
I am wondering if that process couldn't be somewhat automated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants