Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of handshake refusal messages #562

Open
agaffney opened this issue Mar 23, 2024 · 0 comments
Open

Better handling of handshake refusal messages #562

agaffney opened this issue Mar 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@agaffney
Copy link
Contributor

agaffney commented Mar 23, 2024

We are doing unchecked type assertions and accessing array elements without bounds checking. Add better parsing of the 3 different refusal reasons and create specific error types that capture and expose all of the values.

refuseReasonVersionMismatch = [0 , [ * anyVersionNumber ] ]
refuseReasonHandshakeDecodeError = [1 , anyVersionNumber , tstr ]
refuseReasonRefused = [2 , anyVersionNumber , tstr ]
@wolf31o2 wolf31o2 added the enhancement New feature or request label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants