Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLRC-011 and BLRC-012 - Lack of payer/payee sanity checks in execute_deposit and execute_deposit #161

Closed
mootz12 opened this issue Dec 18, 2023 · 1 comment · Fixed by #176
Closed

BLRC-011 and BLRC-012 - Lack of payer/payee sanity checks in execute_deposit and execute_deposit #161

mootz12 opened this issue Dec 18, 2023 · 1 comment · Fixed by #176
Assignees
@mootz12
Labels
backstop The issue relates to the backstop module contract enhancement New feature or request

Comments

@mootz12
Copy link
Contributor

mootz12 commented Dec 18, 2023 •
edited
Loading

Ensure payments are being sent to the correct place by performing address validation for the backstops deposit and donate function.
@mootz12 mootz12 changed the title BL-006 - Lack of payer/payee sanity checks in execute_deposit BL-006 and BL-007 - Lack of payer/payee sanity checks in execute_deposit and execute_deposit Dec 18, 2023
@mootz12 mootz12 self-assigned this Dec 31, 2023
@mootz12 mootz12 changed the title BL-006 and BL-007 - Lack of payer/payee sanity checks in execute_deposit and execute_deposit BLRC-011 and BLRC-012 - Lack of payer/payee sanity checks in execute_deposit and execute_deposit Dec 31, 2023
@mootz12 mootz12 linked a pull request Dec 31, 2023 that will close this issue
Payer payee checks #176
Merged
@mootz12
Copy link
Contributor Author

mootz12 commented Dec 31, 2023

I added additional sanity checks to the pools "request" method as well to prevent the pool address from being used in the event an auth failure occurs.

@mootz12 mootz12 added enhancement New feature or request backstop The issue relates to the backstop module contract labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mootz12 mootz12

Labels
backstop The issue relates to the backstop module contract enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Payer payee checks blend-capital/blend-contracts
2 participants
@mootz12 @markuspluna