Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLRC-018 - Integer underflow in auction scaling mechanism #160

Closed
mootz12 opened this issue Dec 18, 2023 · 2 comments
Closed

BLRC-018 - Integer underflow in auction scaling mechanism #160

mootz12 opened this issue Dec 18, 2023 · 2 comments

Comments

@mootz12
Copy link
Contributor

mootz12 commented Dec 18, 2023

The auction logic sets the start block to cur_block + 1, causing a potential underflow if the auction is filled on the same block, which could result in a loss of capital for the liquidated user.

This is currently blocked by a build configuration, but either checked math and/or tests need to be added to ensure a build configuration change does not break this assumption.

@markuspluna
Copy link
Contributor

Resolved in
#173
Opted to add tests to confirm that an underflow and overflow flags work as intended

@markuspluna
Copy link
Contributor

173 merged

@mootz12 mootz12 changed the title BL-002 - Integer underflow in auction scaling mechanism BLRC-018 - Integer underflow in auction scaling mechanism Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants