Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Peer Dependencies to Support Angular 9 #510

Open
davidvanwyk opened this issue Feb 26, 2020 · 3 comments
Open

Update Peer Dependencies to Support Angular 9 #510

davidvanwyk opened this issue Feb 26, 2020 · 3 comments

Comments

@davidvanwyk
Copy link

Preface

The following issue assumes that there is no functional problem with updating the peer dependencies of this library to Angular 9. Should more than a dependency bump be required, please let me know and perhaps some assistance can be provided.

Issue description

running npm install throws the following warning:

npm WARN [email protected] requires a peer of @angular/common@^8.2.14 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^8.2.14 but none is installed. You must install peer dependencies yourself.

Steps to reproduce and a minimal demo of the problem

npm install with Angular 9

Current behavior

npm install shows warnings due to peer dependencies.

Expected/desired behavior

No warnings should be shown.

@DmitryMalyugin
Copy link

Tried to update angular 8 project to 9 version and got the same problem

@sidikhanrei
Copy link

Any update about this issue?

@exequiel09
Copy link

This is already resolved with #518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants