Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow an arbitrary string for encoding parameter to String type #173

Open
cpcloud opened this issue Aug 28, 2015 · 1 comment
Open

allow an arbitrary string for encoding parameter to String type #173

cpcloud opened this issue Aug 28, 2015 · 1 comment
Assignees
@cpcloud
Labels
bug enhancement
Milestone
0.5.0

Comments

@cpcloud
Copy link
Member

cpcloud commented Aug 28, 2015

I think we're being unnecessarily restrictive here as we're don't actually do anything with the encoding except keep it around for other systems to use. We occasionally translate fixed length string types to a numpy dtype, in which case we would raise if the encoding doesn't make sense in numpy land.
@cpcloud
Copy link
Member Author

cpcloud commented Aug 28, 2015

motivated by this blaze issue: blaze/blaze#1188

@cpcloud cpcloud self-assigned this Aug 28, 2015
@cpcloud cpcloud added this to the 0.4.7 milestone Aug 28, 2015
@cpcloud cpcloud mentioned this issue Sep 1, 2015
Closed
@cpcloud cpcloud modified the milestones: 0.4.7, 0.4.8 Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcloud cpcloud

Labels
bug enhancement
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Let more encodings through and allow registration of encodings
1 participant
@cpcloud