Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management and compatibility with native Asset Bundles #7

Open
dbd5 opened this issue Sep 9, 2017 · 1 comment
Open
Labels

Comments

@dbd5
Copy link

dbd5 commented Sep 9, 2017

If I could just make a suggestion for your consideration;

The native Yii2 AssetBundle design takes care of dependency where an asset must be loaded before another. I've also found that by overriding the AssetBundle init() method, other types of magic is possible.

Secondly, the assets available in Bower should not need to be copied from vendor/bower to another location to work. Perhaps a more elegant configuration design will be for the configuration to match
a local asset in vendor/bower with the cdn based equivalent such that when the CDN is not available or when it is turned off with YII2CDN_OFFLINE, the regular assets are published by Yii, otherwise, the cdn equivalent is published.

Do you think this is an idea worth implementing?

@blacksmoke26
Copy link
Owner

Yeah! Great! I have planned to re-write the code. I will think about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants