-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw Lines via command #180
Conversation
parameters to the main app
Thanks! I'll have a look ASAP! And yes, opacity is per-screen, not per line; safe to leave this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly small PR, good work so far! Only minor change requests.
Thanks for the review! I mainly use Xorg, but I briefly tested this out on wayland using Hyprland and it seems to work as expected. As for the failsafe checks, it seems that Maybe it's a good idea to include example usage of the command, in the README? Everything else should be fixed 👍 |
Code-wise looks good to me, I also tested under Wayland and it draws lines, but only red ones. I'm probably missing out on the correct color format so I guess adding an example to the README is indeed a good idea. Thanks for the good work so far! |
Thanks for the quick reply and the contribution! |
Hello, thanks for making and maintaining gromit-mpx.
This PR aims to implement the feature requested in #161
The original feature request also suggested opacity customization, however by the looks of it, opacity seems to be application-wide rather than individual lines? I was unsure how to implement it here. Would appreciate some guidance in that matter.
I would appreciate if you could review and provide some feedback on this code 😄