From 4c1f4674425ffeb430aa07f3fccbb09837f36a34 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Wed, 30 Aug 2017 08:06:29 -0400 Subject: [PATCH] PLT-7379: Timestamp on deleted, ephemeral, or pending post is a permalink (#7295) * Removed permalink from system messages, general cleanup * Removed permalink from deleted messages * Removed permalink from pending messages * Fixed post_info tests * Changed permalink logic to remove permalinks from ephemeral messages, but leave them in place for system messages. * Fixed check style --- .../post_view/post_info/post_info.jsx | 15 +++++++++++---- webapp/components/post_view/post_time.jsx | 11 ++++++++--- .../__snapshots__/post_info.test.jsx.snap | 7 +++++++ webapp/utils/post_utils.jsx | 19 +++++++++---------- 4 files changed, 35 insertions(+), 17 deletions(-) diff --git a/webapp/components/post_view/post_info/post_info.jsx b/webapp/components/post_view/post_info/post_info.jsx index 2c5b98c6948..cc3133764d5 100644 --- a/webapp/components/post_view/post_info/post_info.jsx +++ b/webapp/components/post_view/post_info/post_info.jsx @@ -9,6 +9,7 @@ import DotMenu from 'components/dot_menu'; import * as Utils from 'utils/utils.jsx'; import * as PostUtils from 'utils/post_utils.jsx'; +import * as ReduxPostUtils from 'mattermost-redux/utils/post_utils'; import {emitEmojiPosted} from 'actions/post_actions.jsx'; import Constants from 'utils/constants.jsx'; import {Posts} from 'mattermost-redux/constants'; @@ -77,7 +78,7 @@ export default class PostInfo extends React.PureComponent { */ addReaction: PropTypes.func.isRequired }).isRequired - } + }; constructor(props) { super(props); @@ -96,12 +97,12 @@ export default class PostInfo extends React.PureComponent { this.setState({showEmojiPicker}); this.props.handleDropdownOpened(showEmojiPicker); - } + }; hideEmojiPicker = () => { this.setState({showEmojiPicker: false}); this.props.handleDropdownOpened(false); - } + }; removePost() { this.props.actions.removePost(this.props.post); @@ -131,7 +132,7 @@ export default class PostInfo extends React.PureComponent { getDotMenu = () => { return this.refs.dotMenu; - } + }; render() { const post = this.props.post; @@ -242,10 +243,16 @@ export default class PostInfo extends React.PureComponent { ); } + // timestamp should not be a permalink if the post has been deleted, is ephemeral message, or is pending + const isPermalink = !(isEphemeral || + Posts.POST_DELETED === this.props.post.state || + ReduxPostUtils.isPostPendingOrFailed(this.props.post)); + return (
@@ -98,6 +99,7 @@ exports[`components/post_view/PostInfo should match snapshot, compact display 1` > @@ -187,6 +189,7 @@ exports[`components/post_view/PostInfo should match snapshot, ephemeral deleted > @@ -222,6 +225,7 @@ exports[`components/post_view/PostInfo should match snapshot, ephemeral post 1`] > @@ -266,6 +270,7 @@ exports[`components/post_view/PostInfo should match snapshot, flagged post 1`] = > @@ -355,6 +360,7 @@ exports[`components/post_view/PostInfo should match snapshot, military time 1`] > @@ -418,6 +424,7 @@ exports[`components/post_view/PostInfo should match snapshot, pinned post 1`] = > diff --git a/webapp/utils/post_utils.jsx b/webapp/utils/post_utils.jsx index 83fb666af97..1ff16a5ab62 100644 --- a/webapp/utils/post_utils.jsx +++ b/webapp/utils/post_utils.jsx @@ -9,7 +9,7 @@ import UserStore from 'stores/user_store.jsx'; import ChannelStore from 'stores/channel_store.jsx'; export function isSystemMessage(post) { - return post.type && (post.type.lastIndexOf(Constants.SYSTEM_MESSAGE_PREFIX) === 0); + return Boolean(post.type && (post.type.lastIndexOf(Constants.SYSTEM_MESSAGE_PREFIX) === 0)); } export function isFromWebhook(post) { @@ -53,11 +53,11 @@ export function getProfilePicSrcForPost(post, user) { } export function canDeletePost(post) { - var isOwner = isPostOwner(post); - var isSystemAdmin = UserStore.isSystemAdminForCurrentUser(); - var isTeamAdmin = TeamStore.isTeamAdminForCurrentTeam() || isSystemAdmin; - var isChannelAdmin = ChannelStore.isChannelAdminForCurrentChannel() || isTeamAdmin; - var isAdmin = isChannelAdmin || isTeamAdmin || isSystemAdmin; + const isOwner = isPostOwner(post); + const isSystemAdmin = UserStore.isSystemAdminForCurrentUser(); + const isTeamAdmin = TeamStore.isTeamAdminForCurrentTeam() || isSystemAdmin; + const isChannelAdmin = ChannelStore.isChannelAdminForCurrentChannel() || isTeamAdmin; + const isAdmin = isChannelAdmin || isTeamAdmin || isSystemAdmin; if (global.window.mm_license.IsLicensed === 'true') { return (global.window.mm_config.RestrictPostDelete === Constants.PERMISSIONS_DELETE_POST_ALL && (isOwner || isChannelAdmin)) || @@ -69,15 +69,14 @@ export function canDeletePost(post) { } export function canEditPost(post, editDisableAction) { - var isOwner = isPostOwner(post); - - var canEdit = isOwner && !isSystemMessage(post); + const isOwner = isPostOwner(post); + let canEdit = isOwner && !isSystemMessage(post); if (canEdit && global.window.mm_license.IsLicensed === 'true') { if (global.window.mm_config.AllowEditPost === Constants.ALLOW_EDIT_POST_NEVER) { canEdit = false; } else if (global.window.mm_config.AllowEditPost === Constants.ALLOW_EDIT_POST_TIME_LIMIT) { - var timeLeft = (post.create_at + (global.window.mm_config.PostEditTimeLimit * 1000)) - Utils.getTimestamp(); + const timeLeft = (post.create_at + (global.window.mm_config.PostEditTimeLimit * 1000)) - Utils.getTimestamp(); if (timeLeft > 0) { editDisableAction.fireAfter(timeLeft + 1000); } else {