Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All hashing functions other sha256 missing from sjcl.js #425

Open
shawnlauzon opened this issue Apr 20, 2021 · 2 comments
Open

All hashing functions other sha256 missing from sjcl.js #425

shawnlauzon opened this issue Apr 20, 2021 · 2 comments

Comments

@shawnlauzon
Copy link

Looking at the documentation, I should be able to use hashing functions such as sjcl.hash.sha1. Unfortunately although I see the code in the repo, the minimized sjcl.js contains no reference to any hashing functions other than the default sha256.

image

From scjl documentation

I'm guessing since only the sha256 function is referenced in the code base, some tree shaking algorithm erroneously removed them during minimization. I was able to copy the sha1 function into my local codebase, but it would obviously be better to be fixed here.

@shawnlauzon shawnlauzon changed the title all hashing functions other sha256 missing from sjcl.js All hashing functions other sha256 missing from sjcl.js Apr 20, 2021
@Jytesh
Copy link

Jytesh commented May 3, 2021

Does
git clone https://github.com/bitwiseshiftleft/sjcl.git && cd sjcl/ && ./configure --with-all && make
work

@igorrendulic
Copy link

igorrendulic commented Oct 29, 2021

The command above works. Any news if updates on npmjs will be made?

Maybe I shall add my current solution how to add master branch to npm managed project:

package.json

"scripts": {
  "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "watch": "ng build --watch --configuration development",
    "test": "ng test",
    "postinstall": "cd node_modules/sjcl && ./configure --with-all && make sjcl.js"
},
"dependencies": {
  "sjcl": "https://github.com/bitwiseshiftleft/sjcl/tarball/master",
...
},
"devDependencies": {
...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants