Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7431] Add support for setting password #710

Closed
wants to merge 1 commit into from
Closed

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Apr 12, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add support for setting a users password in the SDK.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia April 12, 2024 14:04
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 8.57143% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 60.64%. Comparing base (b611974) to head (b38f25e).

Files Patch % Lines
crates/bitwarden/src/auth/password/set.rs 0.00% 19 Missing ⚠️
crates/bitwarden-uniffi/src/auth/mod.rs 0.00% 10 Missing ⚠️
crates/bitwarden/src/auth/client_auth.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   60.83%   60.64%   -0.19%     
==========================================
  Files         173      174       +1     
  Lines       10598    10630      +32     
==========================================
  Hits         6447     6447              
- Misses       4151     4183      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details860d7e57-c0cc-4ec4-b374-f74325dca2c3

No New Or Fixed Issues Found

@Hinton Hinton closed this Apr 12, 2024
@Hinton Hinton deleted the ps/set-password branch May 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant