Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Changelogs for the 1.0 Releases #1122

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Update the Changelogs for the 1.0 Releases #1122

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69f2e55
Update the changelogs for the 1.0 releases
coltonhurst Oct 9, 2024
5411f73
Update bws changelog with run command addition
coltonhurst Oct 9, 2024
650d3f3
Merge branch 'main' into ChangelogUpdateFor1.0Release
coltonhurst Oct 10, 2024
0b3ff38
Merge branch 'main' into ChangelogUpdateFor1.0Release
coltonhurst Oct 11, 2024
28090fc
Move state_opt_out note to changed section for bws
coltonhurst Oct 11, 2024
f293011
Run prettier
coltonhurst Oct 14, 2024
7d9aea0
Merge branch 'main' into ChangelogUpdateFor1.0Release
coltonhurst Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/bitwarden/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [1.0.0] - 2024-09-26

### Added

- Support for secrets sync (#678)
Expand Down
5 changes: 5 additions & 0 deletions crates/bws/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,18 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [1.0.0] - 2024-09-26

### Added

- The ability to edit unassigned secrets with direct permissions. (#906)
- A way to opt out of state by default with the new state_opt_out key (#930)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to any documentation of this?

Suggested change
- A way to opt out of state by default with the new state_opt_out key (#930)
- A way to opt out of state with the new `state_opt_out` setting (#930)

Copy link
Member Author

@coltonhurst coltonhurst Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. I've brought this up with the docs team, if we can get docs made for this I can update it!

I don't think we need to hold up this PR for that, but totally fine if you want to hold it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the phrasing since opt out of state by default is vague, do we by default opt out of state? But we don't have to link it to our docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we currently use state by default. state_opt_out allows you to opt out of using state files. We use state files by default to help prevent the rate limit errors the user would normally run into.

Copy link
Member

@Hinton Hinton Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware, but the phrasing of "A way to opt out of state by default" lacks clarity. And can be interpreted as the default behaviour is to opt out.

Since it's a behaviour change you could put the state_opt_out next to the changed item instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. Updated in 28090fc, let me know what you think. Thanks!

- The `run` command, to run commands with secrets (#621)

coltonhurst marked this conversation as resolved.
Show resolved Hide resolved
### Changed

- Updated MSRV `1.75.0` (#980)
- Use state files by default (#930)

### Removed

Expand Down
Loading