Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to a server with TLS Client Authentication crashes app #4416

Open
1 task done
rohm1 opened this issue Dec 3, 2024 · 2 comments
Open
1 task done

Connecting to a server with TLS Client Authentication crashes app #4416

rohm1 opened this issue Dec 3, 2024 · 2 comments
Labels

Comments

@rohm1
Copy link

rohm1 commented Dec 3, 2024

Steps To Reproduce

#582 has been closed as it concerns the old app. New issue for the new kotlin app

Expected Result

Connecting to a server with TLS client authentication crashes the app

Actual Result

Connecting to a server with TLS client authentication should work

Screenshots or Videos

No response

Additional Context

No response

Build Version

2024.11.1

What server are you connecting to?

Self-host

Self-host Server Version

Vaultwarden 1.32.5

Environment Details

No response

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@rohm1 rohm1 added the bug label Dec 3, 2024
@bitwarden-bot
Copy link

Thank you for your report! We've added this to our internal board for review.
ID: PM-15537

@rohm1
Copy link
Author

rohm1 commented Dec 3, 2024

I have already started working on this. At first I discovered the SDK and started working my way inside it. Then I wanted to test the new SDK within the app but I was still having issues, only to see that the app is using a network provider. I have now started to patch the network provider, but I was wondering when is the SDK provider used. Can somebody familiar with the app help me with that?

Depending on when are the network and SDK provider used, I think we could implement the certificates differently. In case only the network provider is used, it would be a better user experience to import the certificates in Android and load the certificates from the Android trust store in the app. In case both the network and SDK provider are used, we would need to allow the user to select their certificates inside the app, as the SDK cannot use the Android trust store (at least not that I know of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants