Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why we need 'pre-shutdown-ha.sh' #914

Open
huyiqiu opened this issue Feb 6, 2024 · 1 comment
Open

why we need 'pre-shutdown-ha.sh' #914

huyiqiu opened this issue Feb 6, 2024 · 1 comment

Comments

@huyiqiu
Copy link

huyiqiu commented Feb 6, 2024

Hi, I'm not sure why we need 'pre-shutdown-ha.sh' as a preStop hook, since orchestrator can perform auto-failover.

i set '--failover-before-shutdown=false' and kill master pod, the slave pod is promoted as new master, and everything looks fine. Did I miss something important?

@drivebyer
Copy link
Contributor

When shrinking the size, the node that shrinks is the master role, and the preStop hook can perform failover operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants