Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Beta 3.5 Config Import fails when pages don't exist #3043

Open
2 tasks done
davidjoshuaford opened this issue Sep 19, 2024 · 2 comments
Open
2 tasks done

[BUG] Beta 3.5 Config Import fails when pages don't exist #3043

davidjoshuaford opened this issue Sep 19, 2024 · 2 comments
Labels
BUG Something isn't working
Milestone

Comments

@davidjoshuaford
Copy link

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Importing a previous configuration fails in 3.5 with the error message that pages need to be created before they can be imported to.

I also tried creating 99 pages, but the import still failed and ended only with Page 1

I like that new installations default to only 1 page and that new pages can be added as needed. However, when Importing previous configurations, it would be good if those pages (including blank pages between pages with buttons on them) are generated by the import. Hence pages retain their original page number (for the full import behavior).

Since it looks like we are moving away from static page numbers, and will probably rely more on unique page names to reference surface jumps, it would be helpful during import to have a list of checkboxes beside pages to choose which pages we want to import, and those pages cascade to the minimum number of pages required.

Also the import process could be improved to drag buttons from a config import into Companion, similar to how Preset buttons can be dragged into Companion pages.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: Mac M1
- Browser: Chrome
- Companion Version: 3.5.0-7406

Additional context

No response

@davidjoshuaford davidjoshuaford added the BUG Something isn't working label Sep 19, 2024
@Julusian Julusian added this to the v3.5 milestone Sep 21, 2024
@LYMPIA
Copy link

LYMPIA commented Sep 27, 2024

I've encountered the exact same problem while importing a previous config on a new beta or experimental release.
Only one page (the first) is being shown/available after the full import process. No error message is displayed while importing full config.

But when I reinstall the 3.4.1 stable version (or any previous 3.4 versions) all my pages become available again.
The same issue was encountered also with the experimental release.

I've also tried a possible workaround : importing first a fully functionnal configuration with a previous release (ie. 3.4.1) and then install any 3.5 version on top. Alas, it doesn't work at all and the same issue occured : only one page (the first) is being shown on the button page. No other pages are available at all.

Hope this will help...

@ChrisSW58
Copy link

Whilst this may be connected to #3061 the upshot is that once you attempt a clean import, you are unable to do anything. You lose all pages (except for page 1) and all code has naturally gone as well. It successfully stops all development occurring in 3.5. Is therefore a fix for this coming along anytime soon? many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

4 participants