Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 3.4.0 fails to launch on macos 10.15 #3036

Closed
2 tasks done
Julusian opened this issue Sep 15, 2024 · 3 comments
Closed
2 tasks done

[BUG] 3.4.0 fails to launch on macos 10.15 #3036

Julusian opened this issue Sep 15, 2024 · 3 comments
Labels
area/external Tracking an external issue/feature BUG Something isn't working os/mac Something macos specific
Milestone

Comments

@Julusian
Copy link
Member

Julusian commented Sep 15, 2024

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

It fails with the error:

Error: dlopen(/Applications/Companion.app/Contents/Resources/node_modules/@napi-rs/canvas-darwin-x64/skia.darwin-x64.node, 1): Symbol not found: __ZTTNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
  Referenced from: /Applications/Companion.app/Contents/Resources/node_modules/@napi-rs/canvas-darwin-x64/skia.darwin-x64.node
  Expected in: /usr/lib/libc++.1.dylib

This suggests that the canvas library was compiled targetting a newer macos than was being used.

Hopefully this can be lowered to 10.15 again, or if not then the launcher window should have its minimum macos check updated to reflect this change in requirements

Upstream bug report: Brooooooklyn/canvas#896

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: macos 10.15
- Browser: N/A
- Companion Version: 3.4.0

Additional context

No response

@Julusian Julusian added the BUG Something isn't working label Sep 15, 2024
@Julusian Julusian added this to the v3.4 milestone Sep 15, 2024
@Julusian Julusian added area/external Tracking an external issue/feature os/mac Something macos specific labels Sep 15, 2024
@Julusian
Copy link
Member Author

Julusian commented Sep 18, 2024

For anyone who finds this, could you give https://builds.julusian.dev/companion-builds/companion-mac-x64-skia-recompile.dmg a try?
You will need to hold alt, right click then click open on both the dmg and companion for it to launch as it is not fully signed.

If this runs, then I can tidy up the fix and get it into the builds. I don't have a mac that can run 10.15 to try it with myself, so I am hoping this will work

@Julusian Julusian pinned this issue Sep 20, 2024
@Julusian
Copy link
Member Author

could someone give the 1.9.1+381 (or later) build of satellite a test?
I think I have gotten to the bottom of this issue, once it is confirmed that build works I can get it released and applied to companion too

@Julusian
Copy link
Member Author

Julusian commented Sep 26, 2024

This is fixed in 3.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/external Tracking an external issue/feature BUG Something isn't working os/mac Something macos specific
Projects
Status: Done
Development

No branches or pull requests

1 participant