From 74ce9bcc6e321a4da59844761e56c86fa71db0f3 Mon Sep 17 00:00:00 2001
From: Julian Waller <git@julusian.co.uk>
Date: Sun, 16 Oct 2022 16:21:37 +0100
Subject: [PATCH] feat!: remove deprecated fields added for legacy module
 compatability

---
 src/internal/actions.ts  | 10 ----------
 src/internal/feedback.ts | 10 ----------
 src/module-api/base.ts   | 12 ------------
 3 files changed, 32 deletions(-)

diff --git a/src/internal/actions.ts b/src/internal/actions.ts
index f606b3a..f69fdf9 100644
--- a/src/internal/actions.ts
+++ b/src/internal/actions.ts
@@ -199,16 +199,6 @@ export class ActionManager {
 		this.#setActionDefinitions({ actions: hostActions })
 	}
 
-	/** @deprecated */
-	_getAllActions(): Pick<ActionInstance, 'id' | 'actionId' | 'controlId' | 'options'>[] {
-		return Array.from(this.#actionInstances.values()).map((act) => ({
-			id: act.id,
-			actionId: act.actionId,
-			controlId: act.controlId,
-			options: act.options,
-		}))
-	}
-
 	subscribeActions(actionIds: string[]): void {
 		let actions = Array.from(this.#actionInstances.values())
 
diff --git a/src/internal/feedback.ts b/src/internal/feedback.ts
index 734529f..64fd80e 100644
--- a/src/internal/feedback.ts
+++ b/src/internal/feedback.ts
@@ -420,16 +420,6 @@ export class FeedbackManager {
 		}
 	}
 
-	/** @deprecated */
-	_getAllFeedbacks(): Pick<FeedbackInstance, 'id' | 'feedbackId' | 'controlId' | 'options'>[] {
-		return Array.from(this.#feedbackInstances.values()).map((fb) => ({
-			id: fb.id,
-			feedbackId: fb.feedbackId,
-			controlId: fb.controlId,
-			options: fb.options,
-		}))
-	}
-
 	subscribeFeedbacks(feedbackIds: string[]): void {
 		let feedbacks = Array.from(this.#feedbackInstances.values())
 
diff --git a/src/module-api/base.ts b/src/module-api/base.ts
index a6dd044..827f9fa 100644
--- a/src/module-api/base.ts
+++ b/src/module-api/base.ts
@@ -3,9 +3,7 @@ import type { CompanionFeedbackDefinitions } from './feedback.js'
 import type { CompanionPresetDefinitions } from './preset.js'
 import type { InstanceStatus, LogLevel } from './enums.js'
 import type {
-	ActionInstance,
 	ExecuteActionMessage,
-	FeedbackInstance,
 	GetConfigFieldsMessage,
 	GetConfigFieldsResponseMessage,
 	HandleHttpRequestMessage,
@@ -535,11 +533,6 @@ export abstract class InstanceBase<TConfig> implements InstanceBaseShared<TConfi
 		this.#feedbackManager.checkFeedbacksById(feedbackIds)
 	}
 
-	/** @deprecated */
-	_getAllActions(): Pick<ActionInstance, 'id' | 'actionId' | 'controlId' | 'options'>[] {
-		return this.#actionManager._getAllActions()
-	}
-
 	/**
 	 * Call subscribe on all currently known placed actions.
 	 * It can be useful to trigger this upon establishing a connection, to ensure all data is loaded.
@@ -557,11 +550,6 @@ export abstract class InstanceBase<TConfig> implements InstanceBaseShared<TConfi
 		this.#actionManager.unsubscribeActions(actionIds)
 	}
 
-	/** @deprecated */
-	_getAllFeedbacks(): Pick<FeedbackInstance, 'id' | 'feedbackId' | 'controlId' | 'options'>[] {
-		return this.#feedbackManager._getAllFeedbacks()
-	}
-
 	/**
 	 * Call subscribe on all currently known placed feedbacks.
 	 * It can be useful to trigger this upon establishing a connection, to ensure all data is loaded.